Open
Conversation
|
ACTION NEEDED Substrait follows the Conventional Commits The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
mbwhite
force-pushed
the
additional-substrait-builder
branch
from
bd62615 to
d0cc543
Compare
mbwhite
changed the title
mbwhite
force-pushed
the
additional-substrait-builder
branch
from
d0cc543 to
6c079f0
Compare
Signed-off-by: MBWhite <whitemat@uk.ibm.com>
mbwhite
force-pushed
the
additional-substrait-builder
branch
2 times, most recently
from
8618365 to
434df46
Compare
Signed-off-by: MBWhite <whitemat@uk.ibm.com>
mbwhite
force-pushed
the
additional-substrait-builder
branch
from
434df46 to
83fa865
Compare
benbellick
reviewed
Mar 24, 2026
mbwhite
force-pushed
the
additional-substrait-builder
branch
2 times, most recently
from
56aaa2a to
5bdace0
Compare
Signed-off-by: MBWhite <whitemat@uk.ibm.com>
mbwhite
force-pushed
the
additional-substrait-builder
branch
from
5bdace0 to
ef5e526
Compare
benbellick
requested changes
Mar 24, 2026
Member
benbellick
left a comment
benbellick
left a comment
There was a problem hiding this comment.
Just a few comments. Thanks!
Contributor
Author
|
@benbellick updated as suggested :-) |
benbellick
reviewed
Mar 25, 2026
Signed-off-by: MBWhite <whitemat@uk.ibm.com>
mbwhite
force-pushed
the
additional-substrait-builder
branch
from
efabd93 to
fe68836
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow on to pr #767 to fill some missing gaps in the substrait builder. We've recently used the Substrait Builder and found that there some variants and missing gaps in the APIs. We'd subclassed it to add these, so I'm now wanting to push these to the main codebase.
There wasn't a unit test already so I've added a basic one here - which I appreciate will is quite large.